Open
Conversation
ChristianPavilonis
force-pushed
the
fix/github-actions-build-cache
branch
from
e4c644a to
a7f7d4a
Compare
ChristianPavilonis
changed the title
ChristianPavilonis
force-pushed
the
fix/github-actions-build-cache
branch
from
a7f7d4a to
f244195
Compare
aram356
requested changes
Feb 2, 2026
Collaborator
aram356
left a comment
aram356
left a comment
There was a problem hiding this comment.
👍 Looks good overall but need to retain pinned Rust version
ChristianPavilonis
force-pushed
the
fix/github-actions-build-cache
branch
from
5075497 to
12380f6
Compare
aram356
requested changes
Feb 5, 2026
| components: "clippy, rustfmt" | ||
| cache-shared-key: cargo-${{ runner.os }} | ||
|
|
||
| - name: Add wasm32-wasi target |
Collaborator
There was a problem hiding this comment.
🔧 We need this because now the tests fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First run: Rust tests ~5min run
Second run: Rust tests ~1min run